Ticket #671 (closed enhancement: fixed)

Opened 21 months ago

Last modified 21 months ago

Grouping links in rss items, to make download tolerant to broken urls

Reported by: Niluge_KiWi Owned by:
Priority: major Milestone: 1.0
Component: Plugins Keywords: multiple downloads, enclosures, rss, error, broken url, broken link
Cc: Version (eg. 1.0r2700):

Description

So as discussed on irc, here is my patch to implement grouping links:

If "group links" value is set to True, all links from a feed item are stored, and only one entry per item is generated. Links are enclosures plus item fields given by the "link" value, in that order.

Then the download plugin will try each url until one works, instead of just one url.

Example: rss:

url: <url> group links: yes

Download errors are just logged as warning. If all urls have failed, then the entry is rejected, as done previously.

if "group links" is not set or set to false, this patch should be a no op.

Attachments

group_links.patch​ (7.7 KB) - added by Niluge_KiWi 21 months ago.

Change History

Changed 21 months ago by Niluge_KiWi

comment:1 Changed 21 months ago by paranoidi

  • Status changed from new to closed
  • Resolution set to fixed

(In [1391]) Implements #671. Thanks Niluge_KiWi!

comment:2 Changed 21 months ago by Vince2_

Does this works with rewriters? Most of them won't find any URL to rewrite, right?

comment:3 Changed 21 months ago by Niluge_KiWi

I'm not (yet) familiar with rewriters, and haven't modified them with this patch.

I'll look at it to see what I can do.

Note: See TracTickets for help on using tickets.